From 6f36374f6c7bda67815f8acb2268d05601964282 Mon Sep 17 00:00:00 2001 From: Eric Cornelissen Date: Sun, 1 Mar 2020 10:31:08 +0200 Subject: [PATCH 1/3] Escape icon title for object key --- scripts/build-package.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/build-package.js b/scripts/build-package.js index 8ecb5db4ccc7..d2cdd71f1353 100644 --- a/scripts/build-package.js +++ b/scripts/build-package.js @@ -31,7 +31,8 @@ function escape(value) { return value.replace(/'/g, "\\'"); } function iconToKeyValue(icon) { - return `'${icon.title}':${iconToObject(icon)}`; + const iconTitle = escape(icon.title); + return `'${iconTitle}':${iconToObject(icon)}`; } function iconToObject(icon) { return util.format(iconObjectTemplate, From 382eef480215fa51e431217aa12d80949b0296bf Mon Sep 17 00:00:00 2001 From: Eric Cornelissen Date: Sun, 1 Mar 2020 10:34:52 +0200 Subject: [PATCH 2/3] Add McDonald's icon as proof the build works --- _data/simple-icons.json | 5 +++++ icons/mcdonalds.svg | 1 + 2 files changed, 6 insertions(+) create mode 100644 icons/mcdonalds.svg diff --git a/_data/simple-icons.json b/_data/simple-icons.json index 30d0aa07a3c4..a3d28d354b2f 100644 --- a/_data/simple-icons.json +++ b/_data/simple-icons.json @@ -3090,6 +3090,11 @@ "hex": "C01818", "source": "https://www.mcafee.com/" }, + { + "title": "McDonald's", + "hex": "FBC817", + "source": "https://www.mcdonalds.com/gb/en-gb/newsroom.html" + }, { "title": "MDN Web Docs", "hex": "000000", diff --git a/icons/mcdonalds.svg b/icons/mcdonalds.svg new file mode 100644 index 000000000000..6c24399b305a --- /dev/null +++ b/icons/mcdonalds.svg @@ -0,0 +1 @@ +McDonald's icon \ No newline at end of file From d7bab583d3fd599607fe8b2d586b39995f9f911c Mon Sep 17 00:00:00 2001 From: Eric Cornelissen Date: Sun, 1 Mar 2020 10:38:59 +0200 Subject: [PATCH 3/3] revert 382eef480215fa51e431217aa12d80949b0296bf --- _data/simple-icons.json | 5 ----- icons/mcdonalds.svg | 1 - 2 files changed, 6 deletions(-) delete mode 100644 icons/mcdonalds.svg diff --git a/_data/simple-icons.json b/_data/simple-icons.json index a3d28d354b2f..30d0aa07a3c4 100644 --- a/_data/simple-icons.json +++ b/_data/simple-icons.json @@ -3090,11 +3090,6 @@ "hex": "C01818", "source": "https://www.mcafee.com/" }, - { - "title": "McDonald's", - "hex": "FBC817", - "source": "https://www.mcdonalds.com/gb/en-gb/newsroom.html" - }, { "title": "MDN Web Docs", "hex": "000000", diff --git a/icons/mcdonalds.svg b/icons/mcdonalds.svg deleted file mode 100644 index 6c24399b305a..000000000000 --- a/icons/mcdonalds.svg +++ /dev/null @@ -1 +0,0 @@ -McDonald's icon \ No newline at end of file