Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source link support #884

Open
davidroth opened this issue Jan 13, 2021 · 2 comments
Open

Source link support #884

davidroth opened this issue Jan 13, 2021 · 2 comments
Milestone

Comments

@davidroth
Copy link
Contributor

davidroth commented Jan 13, 2021

Source link is a great feature enabling easy and frictionless debugging of nuget packages.
I'd love to have source link support in SimpleInjetor. This would make it very easy to step into SimpleInjector`s source code to understand runtime behavior or to investigate potential bugs.

I recently integrated source link in our own OSS project. I am happy to support you if you have any issues.
Or I could just prepare a pull request if you dont have the time. Just let me know ;-)

@dotnetjunkie
Copy link
Collaborator

This is an interesting idea that has crossed my mind multiple times in the past, but never got further than that because I didn't find it that interesting to invest my time on.

That said, I am very interested to understand more about it, and a PR would certainly be useful. Especially because it gives me a sense of what the consequences are of doing this from a maintainability perspective. Remember: even code written by others typically need to be maintained by me, so that means I'm always careful in adding new features.

This means that I can't guarantee you that I'd accept your PR, but I certainly would like to see it.

@davidroth
Copy link
Contributor Author

davidroth commented Jan 13, 2021

Impact is minimal. Its mostly a csproj/build.props thing. I'll prepare a PR and we can discuss the details there.

davidroth added a commit to davidroth/SimpleInjector that referenced this issue Jan 13, 2021
@dotnetjunkie dotnetjunkie added this to the v6.0 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants