Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open issues for major release #301

Open
11 of 15 tasks
tvdijen opened this issue Aug 14, 2022 · 0 comments
Open
11 of 15 tasks

Open issues for major release #301

tvdijen opened this issue Aug 14, 2022 · 0 comments

Comments

@tvdijen
Copy link
Member

tvdijen commented Aug 14, 2022

  • Upstream blocking issues in xml-security
  • AttributeValue must be able to deal with XML-structures as a value (i.e. Dutch national ID requires an EncryptedID there, but also EPTiD) (Fix AttributeValue to deal with complex content #340)
  • BaseID currently cannot be encrypted because it doesn't implement the encryption interfaces
  • Method getEncryptionBackend for any encryptable element is currently implemented to return null. Needs further implementation, or are we OK with the default?
  • SignedElementTestTrait needs to move to xml-security
  • Many setter-methods are still 'public' and should be migrated to 'protected'
  • We have to manually set $this->dataType = C::XMLENC_ELEMENT in the constructor of an encryptable element. It would be much cleaner if we could set a constant instead of 'abusing' the constructor for this. Will probably require changes to xml-security EncryptableElementTrait
  • We need a solution for the HTTPRequest binding.. It's currently not possible to migrate it to the new signing interface
  • We're not passing the container's blacklisted algorithms anywhere
  • grep -i TODO and fix those
  • Drop the Certificate/ directory and use the similar classes from xml-security
  • Rewrite the files in the Configuration/ directory. Create Configuration-classes for IdentityProvider and ServiceProvider with public getters/setters that can be used by implementations using this library.
  • The ecp:Request element has not yet been implemented (Add some more elements for the ecp-namespace #341)
  • The ecp:RelayState element has not yet been implemented (Add some more elements for the ecp-namespace #341)
  • The ecp:SubjectConfirmation element has not yet been implemented (Add some more elements for the ecp-namespace #341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant