Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0: bin/translateAttributes.php is broken #1669

Open
tvdijen opened this issue Jul 9, 2022 · 1 comment
Open

2.0: bin/translateAttributes.php is broken #1669

tvdijen opened this issue Jul 9, 2022 · 1 comment

Comments

@tvdijen
Copy link
Member

tvdijen commented Jul 9, 2022

Describe the bug
We have removed the old json dictionaries and upgraded gettext, but this script was neglected.

@monkeyiq
Copy link
Contributor

It appears that the functionality of this script in the 1.x series was to bring in the translations from dictionaries/attributes.translation.json with the default English from dictionaries/attributes.definition.json. If there is a mapping in attributemap/name2urn.php that is not in the attributes*.json files then it would be added with a blank translation.

These dictionaries/attributes.*.json files do not seem to exist in 2.0 and 2.1 releases.

Perhaps then the update to bin/translateAttributes.php would be to load the po files and ensure there is a blank entry for items in attributemap/name2urn.php that are not in the po files already? If this seems sensible and I have not missed anything then I can make a move on that as an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants