SMTP configuration not working - sender and receiver are both 'technicalcontact_email'

[pkxb]

Describe the bug
I've set up SMTP in config/config.php using the following settings:

'technicalcontact_email' => 'admin@example.com',
'mail.transport.method' => 'smtp',
mail.transport.options' => [
'host' => 'mx.example.com',
'port' => 587,
'username' => 'test@example.com',
'password' => 'passw0rd',
'security' => 'tls',
],

The problem is that SimpleSAML authenticates as test@example.com but tries to send the email as admin@example.com which leads to the following error message on the email server:

NOQUEUE: reject: RCPT from test.example.com[1.2.3.4]: 553 5.7.1 <admin@example.com>: Sender address rejected: not owned by user test@example.com; from=<admin@example.com> to=<admin@example.com> proto=E SMTP helo=<test.example.com>

Expected behavior
I'm expecting the client to login as test@example.com and send the email as test@example.com and not as admin@example.com which should be the recipient address only. To put in other words: I'm expecting the SMTP login and sender to be $config['mail.transport.options']['username'] and the receiver to be $config['technicalcontact_email'] , but now $config['technicalcontact_email'] is used as the sender.

Additional information
My SimpleSAML version is 1.19.

[tvdijen]

Is this about sending error reports? Or cron?

Your proposed solution is problematic, because a username is not necessarily an email address.
We can of course add another config-setting to configure the 'From' address.

[pkxb]

Hi, I'm referring to the error reports.

Having the possibility to set the from address would be helpful in my opinion. Otherwise (please correct me if I'm wrong) I can send only messages to myself ($config['technicalcontact_email'] -> $config['technicalcontact_email'] if $config['mail.transport.options']['username'] is not being used as the from when being an email address).

[tvdijen]

The technical contact email is being abused there anyway, because it's meant to set the technical contact inside metadata, so it makes perfect sense to create new config settings for this. I'll get to it ASAP.

[thijskh]

Technicalcontact_email is just a default for the metadata contacts, but is also primarily the address SSP sends emails to about issues (error reports, cron mails ...). So that probably needs to remain. Indeed what could be improved is to configure the From of any of these system emails.