Skip to content

Commit

Permalink
Refactor file paths and name (#150)
Browse files Browse the repository at this point in the history
* Refactor file paths and names, and rename packages within files.

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

* feat(album): add error handling for album pattern parsing

This commit adds error handling for parsing the album pattern in the deleteAlbum function. If the album pattern cannot be parsed, an error message is returned. This ensures that any errors in parsing the album pattern are properly handled.

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>

---------

Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
  • Loading branch information
rodneyosodo committed Feb 9, 2024
1 parent 7bc97ee commit c65215b
Show file tree
Hide file tree
Showing 58 changed files with 24 additions and 26 deletions.
6 changes: 2 additions & 4 deletions cmdtool/cmdalbum/cmdalbum.go → cmd/album/album.go
@@ -1,4 +1,4 @@
package cmdalbum
package album

import (
"context"
Expand Down Expand Up @@ -52,9 +52,7 @@ func deleteAlbum(ctx context.Context, ic *immich.ImmichClient, log *logger.Log,
if len(args) > 0 {
re, err := regexp.Compile(args[0])
if err != nil {
if err != nil {
return fmt.Errorf("album pattern %q can't be parsed: %w", cmd.Arg(0), err)
}
return fmt.Errorf("album pattern %q can't be parsed: %w", cmd.Arg(0), err)
}
app.pattern = re
} else {
Expand Down
2 changes: 1 addition & 1 deletion cmdduplicate/duplicate.go → cmd/duplicate/duplicate.go
@@ -1,7 +1,7 @@
/*
Check the list of photos to list and discard duplicates.
*/
package cmdduplicate
package duplicate

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion cmdmetadata/metadatacmd.go → cmd/metadata/metadata.go
@@ -1,4 +1,4 @@
package cmdmetadata
package metadata

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion cmdstack/cmdstack.go → cmd/stack/stack.go
@@ -1,4 +1,4 @@
package cmdstack
package stack

import (
"context"
Expand Down
6 changes: 3 additions & 3 deletions cmdtool/cmdtool.go → cmd/tool/tool.go
@@ -1,10 +1,10 @@
package cmdtool
package tool

import (
"context"
"fmt"

"github.com/simulot/immich-go/cmdtool/cmdalbum"
"github.com/simulot/immich-go/cmd/album"
"github.com/simulot/immich-go/immich"
"github.com/simulot/immich-go/logger"
)
Expand All @@ -15,7 +15,7 @@ func CommandTool(ctx context.Context, ic *immich.ImmichClient, logger *logger.Lo
args = args[1:]

if cmd == "album" {
return cmdalbum.AlbumCommand(ctx, ic, logger, args)
return album.AlbumCommand(ctx, ic, logger, args)
}
}

Expand Down
2 changes: 1 addition & 1 deletion cmdupload/assets.go → cmd/upload/assets.go
@@ -1,4 +1,4 @@
package cmdupload
package upload

import (
"fmt"
Expand Down
2 changes: 1 addition & 1 deletion cmdupload/configuration.go → cmd/upload/configuration.go
@@ -1,4 +1,4 @@
package cmdupload
package upload

import (
"errors"
Expand Down
@@ -1,7 +1,7 @@
//go:build e2e
// +build e2e

package cmdupload
package upload

import (
"context"
Expand Down
@@ -1,4 +1,4 @@
package cmdupload
package upload

import "testing"

Expand Down
2 changes: 1 addition & 1 deletion cmdupload/upload.go → cmd/upload/upload.go
@@ -1,6 +1,6 @@
// Command Upload

package cmdupload
package upload

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion cmdupload/upload_test.go → cmd/upload/upload_test.go
@@ -1,4 +1,4 @@
package cmdupload
package upload

import (
"cmp"
Expand Down
20 changes: 10 additions & 10 deletions main.go
Expand Up @@ -10,11 +10,11 @@ import (
"runtime"
"strings"

"github.com/simulot/immich-go/cmdduplicate"
"github.com/simulot/immich-go/cmdmetadata"
"github.com/simulot/immich-go/cmdstack"
"github.com/simulot/immich-go/cmdtool"
"github.com/simulot/immich-go/cmdupload"
"github.com/simulot/immich-go/cmd/duplicate"
"github.com/simulot/immich-go/cmd/metadata"
"github.com/simulot/immich-go/cmd/stack"
"github.com/simulot/immich-go/cmd/tool"
"github.com/simulot/immich-go/cmd/upload"
"github.com/simulot/immich-go/helpers/myflag"
"github.com/simulot/immich-go/helpers/tzone"
"github.com/simulot/immich-go/immich"
Expand Down Expand Up @@ -168,15 +168,15 @@ func Run(ctx context.Context, log *logger.Log) (*logger.Log, error) {
cmd := flag.Args()[0]
switch cmd {
case "upload":
err = cmdupload.UploadCommand(ctx, app.Immich, app.Logger, flag.Args()[1:])
err = upload.UploadCommand(ctx, app.Immich, app.Logger, flag.Args()[1:])
case "duplicate":
err = cmdduplicate.DuplicateCommand(ctx, app.Immich, app.Logger, flag.Args()[1:])
err = duplicate.DuplicateCommand(ctx, app.Immich, app.Logger, flag.Args()[1:])
case "metadata":
err = cmdmetadata.MetadataCommand(ctx, app.Immich, app.Logger, flag.Args()[1:])
err = metadata.MetadataCommand(ctx, app.Immich, app.Logger, flag.Args()[1:])
case "stack":
err = cmdstack.NewStackCommand(ctx, app.Immich, app.Logger, flag.Args()[1:])
err = stack.NewStackCommand(ctx, app.Immich, app.Logger, flag.Args()[1:])
case "tool":
err = cmdtool.CommandTool(ctx, app.Immich, app.Logger, flag.Args()[1:])
err = tool.CommandTool(ctx, app.Immich, app.Logger, flag.Args()[1:])
default:
err = fmt.Errorf("unknown command: %q", cmd)
}
Expand Down

0 comments on commit c65215b

Please sign in to comment.