Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alfy-init freezing with some editors (e.g. vim) #137

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

gil
Copy link
Contributor

@gil gil commented Jun 22, 2021

Hey folks!

When you have a config.json file in your project, during installation alfy-init is gonna call alfred-config to copy this file and open on the default editor.

There's a problem when you have a terminal-based editor such as vim set, postinstall script is gonna freeze waiting for the editor to close, but it's never visible for the user in the first place, so you'll be stuck.

This PR tries to fix this issue by inheriting stdio.

If you wanna try to reproduce this, simply create a config.json file in your alfy project, run EDITOR=vim npm install and you should be stuck as well.

@sindresorhus sindresorhus merged commit 60b4ea7 into sindresorhus:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants