Add support for Iterable, require Node.js 8, add TypeScript definition
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Apr 5, 2019
| ``` | ||
| */ | ||
| declare function arrify(value: null | undefined): []; | ||
| declare function arrify(value: string): [string]; |
There was a problem hiding this comment.
I don't think you should special-case string. It's a separate check in the code as string is also iterable, so otherwise it would be used as an iterable instead of a string.
How about this instead?
Suggested change
| declare function arrify(value: string): [string]; | |
| declare function arrify<ValueType(value: ValueType): [ValueType]; |
Can you also add a (type and normal) test for arrify(1) and arrify(true)?
There was a problem hiding this comment.
You're right about the catch-all case, missed this one. string is however iterable, so we still have to special-case it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.