TypeScript - Add overload for ReadonlyArray
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BendingBender
suggested changes
Apr 5, 2019
Co-Authored-By: ajafff <klaus.meinhardt1@gmail.com>
BendingBender
approved these changes
Apr 6, 2019
|
Thank you! |
sindresorhus
changed the title
ReadonlyArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If passed an array
arrifyreturns the same refrence. With the current type declarations this would convert aReadonlyArray<T>to a mutableArray<T>because it matches the overload withIterable<T>.This adds an overload to make sure readonly arrays are not mutated after being passed through arrify.