Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Invalid URL remark-lint:double-link, false positive? #114

Open
probonopd opened this issue Aug 3, 2020 · 8 comments
Open

Getting Invalid URL remark-lint:double-link, false positive? #114

probonopd opened this issue Aug 3, 2020 · 8 comments

Comments

@probonopd
Copy link

Hello @sindresorhus I am getting a validation error which I suspect to be a false positive:

My list:

The validation error:

1:1  Invalid URL: http:#appimage-discovery        remark-lint:double-link

Full log:

https://github.com/AppImage/awesome-appimage/runs/939913779?check_suite_focus=true#step:5:8

What does it mean, how can I fix it? Thank you very much.

@sindresorhus
Copy link
Owner

// @Scrum

@Scrum
Copy link
Contributor

Scrum commented Aug 5, 2020

@probonopd @sindresorhus Thanks for the find, I have already made the necessary changes to the package remark-lint-double-link, let me know if something goes wrong after the update.

@probonopd
Copy link
Author

probonopd commented Aug 12, 2020

Thank you very much @Scrum - this solves the particular issue.

But now I am getting what looks like other false positives:

  ✖  193:3   https://www.youtube.com/watch?v=XTGn_JqmDu0                                    remark-lint:double-link
  ✖  203:3   https://www.youtube.com/watch?v=nzZ6Ikc7juw                                    remark-lint:double-link
  ✖  204:3   https://www.youtube.com/watch?v=7fPShv-8Z_4                                    remark-lint:double-link

Could it be that what follows after the ? is ignored?

@Scrum
Copy link
Contributor

Scrum commented Aug 12, 2020

@probonopd Hi, it will take me a while to explore the possibility of including parameters in the plugin

@jthegedus
Copy link

@Scrum until then, is there an ignore for this particular rule but only applying to a specific URL? IE: ignore all YouTube links?

@Scrum
Copy link
Contributor

Scrum commented Aug 13, 2020

@probonopd @jthegedus

@Scrum until then, is there an ignore for this particular rule but only applying to a specific URL? IE: ignore all YouTube links?

Yes, now you can set the ignore flag for such link types, for example

- [puper-link-1](http://link-1)
- [puper-link-1](http://link-2)
<!--lint ignore double-link-->
- [Produce an AppImage that bundles everything with go-appimage](https://www.youtube.com/watch?v=XTGn_JqmDu0)
- [puper-link-1](http://link-1)
- [AppImage: Portable applications for Linux](https://www.youtube.com/watch?v=nzZ6Ikc7juw)
- [Comparing Linux Package Formats - Deb, Flatpak, AppImage, etc.](https://www.youtube.com/watch?v=7fPShv-8Z_4)

In this case, you will receive only one error '2:3-2:32: http://link-1',

@ugurkanates
Copy link

ugurkanates commented Sep 27, 2020

Also happening to me as well , not only YouTube either. Google scholar also results the same.

@Scrum
Copy link
Contributor

Scrum commented Sep 28, 2020

resolved in Scrum/remark-lint-double-link#6 Now query parameters will participate in validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants