Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camelcase-keys & snakecases-keys inconsistent default behaviour #27

Open
boedy opened this issue Oct 30, 2018 · 0 comments
Open

camelcase-keys & snakecases-keys inconsistent default behaviour #27

boedy opened this issue Oct 30, 2018 · 0 comments

Comments

@boedy
Copy link

boedy commented Oct 30, 2018

@sindresorhus @bendrucker

Both of your packages communicate a similar api, but you don't use the same defaults. The deep option for camelcase-keys is false where it is true for snakecase-keys. I would suggest standardising the default to prevent unsuspected behaviour as I experienced first hand.

I believe defaulting the deep option to true aligns with most preferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant