Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TS4.8 #98

Merged
merged 3 commits into from Aug 29, 2022
Merged

Add support for TS4.8 #98

merged 3 commits into from Aug 29, 2022

Conversation

Masa-Shin
Copy link
Contributor

@Masa-Shin Masa-Shin commented Aug 29, 2022

  • Fix typing
  • update tsd to the version using TS4.8

The code was tested with both version of tsd.

Fixes #97

  The T[P] in the type definition of CamelCaseKeys could be anything and did not always satisfy the constraint of the generics argument T.
@Masa-Shin Masa-Shin changed the title Fix type for supporting TS4.8 Add support for TS4.8 Aug 29, 2022
@sindresorhus sindresorhus merged commit 5e7f7c5 into sindresorhus:main Aug 29, 2022
@sindresorhus
Copy link
Owner

Thanks for fixing :)

Copy link

@slymullar2k50 slymullar2k50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: typing errors with typescript 4.8
3 participants