Handle Unicode character casing and require Node.js 10 #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what & why
Adds handling of non-ASCII character casing.
After merging this PR a string like
розовый_пушистый-единороги
will be converted toрозовыйПушистыйЕдинороги
(or toРозовыйПушистыйЕдинороги
when pascal case is on) andLicorne époustouflante
tolicorneÉpoustouflante
(/LicorneÉpoustouflante
).Fixes #60
choices
Explanation of choices that might seem non-obvious:
\w
with[\p{Alpha}\p{N}_]
which is as close to the original intent of\w
as I could muster (which is[A-Za-z0-9_]
according to mdn)Because the regular expression already implies it's an upper case character the
character.toUpperCase() === character
would always yieldtrue
anyway (but holler if I missed something!)