Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preserveConsecutiveUppercase option #78

Merged
merged 11 commits into from Oct 28, 2020
Merged

Add preserveConsecutiveUppercase option #78

merged 11 commits into from Oct 28, 2020

Conversation

rocktimsaikia
Copy link
Contributor

@rocktimsaikia rocktimsaikia commented Oct 6, 2020

fixes #76
Builds on the reviews left on the previous attempt #64

  • Added test cases
  • Updated README
  • Synced the updated examples of readme with declaration file
  • Made some additional irrelevant to the issue tweaks [like removing spread operators from a single property ]

This to

options = {
       ...{pascalCase: false},
       ...options
};

to

options = {
       pascalCase: false,
       ...options
};

// @sindresorhus

readme.md Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Can you fix the merge conflict?

@sindresorhus sindresorhus changed the title add support for preserveConsecutiveUppercase option Add preserveConsecutiveUppercase option Oct 25, 2020
@rocktimsaikia
Copy link
Contributor Author

@sindresorhus Sure. I just resolved the merge conflicts. This pr can be merged now .

index.d.ts Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
rocktimsaikia and others added 3 commits October 27, 2020 16:02
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus sindresorhus merged commit e2c4891 into sindresorhus:master Oct 28, 2020
@sindresorhus
Copy link
Owner

Thanks :)

@rocktimsaikia
Copy link
Contributor Author

Thanks to you. I am new to open source and started contributing to open source just a few months ago only through your projects :)
// @sindresorhus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preserveConsecutiveUppercase option
2 participants