More parameters for option rename function

[ddhp]

Hi, first of all, thanks for this amazing library.

I am wondering if it's possible to pass srcPath and dest to rename function here:
https://github.com/sindresorhus/cpy/blob/master/index.js#L18

What I want to do is to rename the file with the hash value, so I need srcPath to do that.

Thanks!

[sindresorhus]

Hmm, another idea. We would pass the callback two arguments, source and destination. Both are a custom file object:

{
	path: '/Users/sindresorhus/foo.txt',
	name: 'foo.txt',
	nameWithoutExtension: 'foo',
	extension: 'txt'
}

source would be immutable (Object.freeze()), while destination would be mutable, so to change something, you just set one of the properties. You can set any of the properties and it will be handled correctly. We could use Proxy for this.

I think this would make it really nice to use:

const cpy = require('cpy');

(async () => {
	await cpy('foo.js', 'destination', {
		rename: (source, destination) => {
			if (source.nameWithoutExtension === 'foo') {
				destination.nameWithoutExtension = 'bar';
			}
		}
	});
})();

If you just want to change the extension, you could do:

const cpy = require('cpy');

(async () => {
	await cpy('foo.js', 'destination', {
		rename: (source, destination) => {
			if (source.nameWithoutExtension === 'foo') {
				destination.extension = 'ts';
			}

			console.log(destination.name);
			//=> 'foo.ts'
		}
	});
})();

I think I prefer this approach.

[adamduncan]

@sindresorhus This does sound like a nice approach indeed. Was there desire to move ahead with this?

[sindresorhus]

My above proposal is how it should be implemented. It's not something I plan to work on anytime soon though. However, good PRs are always welcome.