Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add followSymlinks option #62

Open
sindresorhus opened this issue Jun 11, 2019 · 8 comments
Open

Add followSymlinks option #62

sindresorhus opened this issue Jun 11, 2019 · 8 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement help wanted

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Jun 11, 2019

Issuehunt badges

Should be off by default.

This task also involves adding it to https://github.com/sindresorhus/cpy-cli

Inspiration:


IssueHunt Summary

Sponsors (Total: $40.00)

Become a sponsor now!

Or submit a pull request to get the deposits!

Tips

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jun 11, 2019
@IssueHuntBot
Copy link

@issuehunt has funded $40.00 to this issue.


@itaisteinherz
Copy link

I'd like to work on this.

@Idered
Copy link
Contributor

Idered commented Oct 4, 2021

I just tested this:

  1. Created test-symlink and ran yarn init
  2. Used yarn link in that directory
  3. Used yarn link "test-symlink" in cpy project
  4. Copied all package.json files except test-symlink/package.json using
await cpy(['node_modules/**/package.json'], 'dest');
  1. Copied all package.json files, including test-symlink/package.json using
await cpy(['node_modules/**/package.json'], 'dest', {
    followSymbolicLinks: true,
});

It works

@sindresorhus
Copy link
Owner Author

@Idered I'm confused, cpy doesn't have a followSymbolicLinks option.

@Idered
Copy link
Contributor

Idered commented Oct 5, 2021

@sindresorhus Since cpy accepts fast-glob options, it's supported out of the box https://github.com/mrmlnc/fast-glob#followsymboliclinks

@sindresorhus
Copy link
Owner Author

Ah right. It's such a common need, so I think we should directly document it in the readme here.

@Idered
Copy link
Contributor

Idered commented Oct 5, 2021

Do you want to create PR or should I take care of it?

You can take off bounty, docs update PR is not worth it.

@sindresorhus
Copy link
Owner Author

I don't plan to work on this, so PR welcome if you want to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants