Add ignoreJunk option
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitecrownclown
force-pushed
the
feat/ignore-junk
branch
from
145a2a8
to
cdf57cb
Compare
|
@whitecrownclown Don't force-push. It makes it impossible for me to see what you changed, so I'm forced to re-review everything instead of just the new changes. |
sindresorhus
reviewed
Jul 7, 2019
sindresorhus
reviewed
Jul 7, 2019
|
You also need to add it to https://github.com/sindresorhus/cpy/blob/master/index.d.ts |
|
Can you fix the merge conflict? |
whitecrownclown
force-pushed
the
feat/ignore-junk
branch
from
5d43a82
to
d96b460
Compare
whitecrownclown
force-pushed
the
feat/ignore-junk
branch
from
d96b460
to
9b86940
Compare
|
I did fix the conflict, but unfortunately I messed up the rebase and had to force push.. Sorry about that. |
|
Looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sindresorhus
Fixes #57
ignoreJunkoption, defaults tofalseOne thing i encountered when writing tests for this. If you glob using
*, hidden files will be ignored by default.