Pass dictionary suggestions to the menu option function

[smithalan92]

At the moment, if you need to use the menu function to build a custom menu for whatever reason, you need to duplicate all the work the module does to correctly put spellcheck suggestions into the menu.

This tweak passes the dictionarySuggestions Array generated by the module as a 4th param to the menu function, so it can be used as is to provide spellcheck in the custom menu template.

[sindresorhus]

You need to update index.d.ts too.

[sindresorhus]

I'm also curious why you're using the menu option? It should really just be a last option. Maybe there's something that can be done to enable your use-case.

[smithalan92]

Hey @sindresorhus , thanks for taking a look. I've pushed those changes as requested.

I'm also curious why you're using the menu option? It should really just be a last option. Maybe there's something that can be done to enable your use-case.

The reason we need to use the menu option is more to do with how our app is structured, rather than defaults of the module. Basically, Electron loads a web app in a webview, but we load specific version urls to make sure the desktop/web app builds always match. So a desktop version of 1.0.0 would load a url like /app-version/1.0.0 , however we don't want to expose these version urls to a user, so when links are opened externally, or copied etc.. , we need to rewrite those urls from
/app-version/1.0.0 to /app to keep it nice and simple for an end user, using the menu option allows us to do to this.

[sindresorhus]

The reason we need to use the menu option is more to do with how our app is structured, rather than defaults of the module. Basically, Electron loads a web app in a webview, but we load specific version urls to make sure the desktop/web app builds always match. So a desktop version of 1.0.0 would load a url like /app-version/1.0.0 , however we don't want to expose these version urls to a user, so when links are opened externally, or copied etc.. , we need to rewrite those urls from
/app-version/1.0.0 to /app to keep it nice and simple for an end user, using the menu option allows us to do to this.

So you use menu because you need the transform option for some of the items? Maybe we could add a global transform option or something.