Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download" actions do not work in webviews #122

Open
GiovanH opened this issue Oct 20, 2020 · 2 comments
Open

"Download" actions do not work in webviews #122

GiovanH opened this issue Oct 20, 2020 · 2 comments

Comments

@GiovanH
Copy link

GiovanH commented Oct 20, 2020

"Download" actions pass the webview as a window to electron-dl, but electron-dl does not support webviews. Electron-dl would need to change its specification or electron-context-menu should pass the parent window instead.

@sindresorhus
Copy link
Owner

I think this should be fixed in electron-dl.

@GiovanH
Copy link
Author

GiovanH commented Mar 20, 2024

Is there any reason electron-context-menu shouldn't pass the parent window as suggested, at least as a stopgap measure? Perhaps along with a console warning describing the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants