Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #34

Open
jimbol opened this issue Mar 29, 2017 · 4 comments
Open

Testing #34

jimbol opened this issue Mar 29, 2017 · 4 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement help wanted

Comments

@jimbol
Copy link

jimbol commented Mar 29, 2017

Issuehunt badges

I'm disinclined to use libraries with tests. We should add them!

There is a $40.00 open bounty on this issue. Add more on Issuehunt.

@sindresorhus
Copy link
Owner

I totally agree, but not sure how to test it. Suggestions and pull requests welcome.

@jimbol
Copy link
Author

jimbol commented Mar 29, 2017

I think unit tests would get it most of the way covered without too much hassle. Integration tests with Electron is a different story.

I could set up unit tests with mocha if that would interest you.

sindresorhus added a commit that referenced this issue Apr 1, 2017
@sindresorhus
Copy link
Owner

Agreed, some unit test for the non-Electron specific behavior would be great. I added some initial test skeleton. There are two possible solutions, either extract the non-Electron functionality out into separate functions and export those for testing, or mock some of the Electron APIs.

A pull request would be very much welcome :)

sindresorhus added a commit that referenced this issue Apr 1, 2017
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement help wanted
Projects
None yet
Development

No branches or pull requests

3 participants