Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add menu item for looking up a word on macOS #71

Merged
merged 3 commits into from May 30, 2019
Merged

Add menu item for looking up a word on macOS #71

merged 3 commits into from May 30, 2019

Conversation

caesar
Copy link
Contributor

@caesar caesar commented May 26, 2019

Adds a menu item for looking up a selected word or phrase on macOS.

Enabled by default on macOS, can be disabled using showLookUpWord: false.

Closes #3.

Screenshots:

Screenshot 2019-05-26 at 19 17 20

Screenshot 2019-05-26 at 19 17 41

Screenshot 2019-05-26 at 19 18 24

sindresorhus
sindresorhus requested changes May 29, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@caesar
Copy link
Contributor Author

caesar commented May 29, 2019

Would you like me to rebase and squash or will you do that when you merge?

Note that the implementation of options.showLookUpSelection as an inverse boolean is actually dependent on 2529d65 (#69) in order to work properly when disabled…

@sindresorhus
Copy link
Owner

Would you like me to rebase and squash or will you do that when you merge?

When I merge.

@sindresorhus sindresorhus merged commit 35f3dd0 into sindresorhus:master May 30, 2019
caesar
caesar commented May 30, 2019
View reviewed changes
index.js Show resolved Hide resolved
@caesar caesar mentioned this pull request May 31, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add menu item for looking up a word on OS X
2 participants
@caesar @sindresorhus