no-array-callback-reference: Ignore primitive wrappers in `Array#ma…

…p()` (#1642)
sindresorhus · Dec 17, 2021 · 0362c09 · 0362c09
1 parent 0866b41
commit 0362c09
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/rules/no-array-callback-reference.js b/rules/no-array-callback-reference.js
@@ -49,14 +49,10 @@ const iteratorMethods = [
 	],
 	[
 		'flatMap',
-		{
-			ignore: [
-				'Boolean',
-			],
-		},
 	],
 	[
-		'forEach', {
+		'forEach',
+		{
 			returnsUndefined: true,
 		},
 	],
@@ -65,7 +61,11 @@ const iteratorMethods = [
 		{
 			extraSelector: '[callee.object.name!="types"]',
 			ignore: [
+				'String',
+				'Number',
+				'BigInt',
 				'Boolean',
+				'Symbol',
 			],
 		},
 	],

diff --git a/test/no-array-callback-reference.mjs b/test/no-array-callback-reference.mjs
@@ -57,7 +57,14 @@ test({
 		...reduceLikeMethods.map(method => `this.${method}(fn)`),
 
 		// `Boolean`
+		'foo.find(Boolean)',
+
+		// Primitive wrappers are ignored
+		'foo.map(String)',
+		'foo.map(Number)',
+		'foo.map(BigInt)',
 		'foo.map(Boolean)',
+		'foo.map(Symbol)',
 
 		// Not `CallExpression`
 		'new foo.map(fn);',