no-unreadable-array-destructuring: Fix crash on destructuring in `f…

…or…of` loop (#1076)
sindresorhus · Jan 27, 2021 · 11ce1bc · 11ce1bc
1 parent 172f116
commit 11ce1bc
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 2 deletions.
diff --git a/rules/no-unreadable-array-destructuring.js b/rules/no-unreadable-array-destructuring.js
@@ -31,6 +31,7 @@ const create = context => {
 			if (
 				parent.type === 'VariableDeclarator' &&
 				parent.id === node &&
+				parent.init !== null &&
 				nonNullElements.length === 1
 			) {
 				const [element] = nonNullElements;

diff --git a/test/integration/projects.js b/test/integration/projects.js
@@ -140,7 +140,9 @@ module.exports = [
 	// #903
 	'https://github.com/mattermost/mattermost-webapp',
 	// #1030
-	'https://github.com/astrofox-io/astrofox'
+	'https://github.com/astrofox-io/astrofox',
+	// #1075
+	'https://github.com/jaredLunde/masonic'
 ].map(project => {
 	if (typeof project === 'string') {
 		project = {repository: project};

diff --git a/test/no-unreadable-array-destructuring.js b/test/no-unreadable-array-destructuring.js
@@ -47,6 +47,7 @@ test.snapshot({
 		// Multiple declarations
 		'let [,,thirdElement] = foo, anotherVariable = bar;',
 		// Default value
-		'let [,,thirdElement = {}] = foo;'
+		'let [,,thirdElement = {}] = foo;',
+		'for (const [, , id] of shuffle(list)) {}'
 	]
 });
diff --git a/test/snapshots/no-unreadable-array-destructuring.js.md b/test/snapshots/no-unreadable-array-destructuring.js.md
@@ -270,3 +270,13 @@ Generated by [AVA](https://avajs.dev).
     > 1 | let [,,thirdElement = {}] = foo;␊
         |     ^^^^^^^^^^^^^^^^^^^^^ Array destructuring may not contain consecutive ignored values.␊
     `
+
+## Invalid #21
+      1 | for (const [, , id] of shuffle(list)) {}
+
+> Error 1/1
+
+    `␊
+    > 1 | for (const [, , id] of shuffle(list)) {}␊
+        |            ^^^^^^^^ Array destructuring may not contain consecutive ignored values.␊
+    `
diff --git a/test/snapshots/no-unreadable-array-destructuring.js.snap b/test/snapshots/no-unreadable-array-destructuring.js.snap