prefer-string-trim-start-end: Check optional chaining (#1768)

sindresorhus · Mar 30, 2022 · 1920597 · 1920597
1 parent c501243
commit 1920597
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/rules/prefer-string-trim-start-end.js b/rules/prefer-string-trim-start-end.js
@@ -10,6 +10,7 @@ const selector = [
 	methodCallSelector({
 		methods: ['trimLeft', 'trimRight'],
 		argumentsLength: 0,
+		includeOptionalMember: true,
 	}),
 	' > .callee',
 	' > .property',

diff --git a/test/prefer-string-trim-start-end.mjs b/test/prefer-string-trim-start-end.mjs
@@ -6,6 +6,7 @@ const {test} = getTester(import.meta);
 test.snapshot({
 	valid: [
 		'foo.trimStart()',
+		'foo.trimStart?.()',
 		'foo.trimEnd()',
 		// Not `CallExpression`
 		'new foo.trimLeft();',
@@ -40,6 +41,6 @@ test.snapshot({
 					/* comment */
 				)
 		`,
-		'foo.trimLeft()',
+		'foo?.trimLeft()',
 	],
 });
diff --git a/test/snapshots/prefer-string-trim-start-end.mjs.md b/test/snapshots/prefer-string-trim-start-end.mjs.md
@@ -113,17 +113,17 @@ Generated by [AVA](https://avajs.dev).
     `
 
 ## Invalid #7
-      1 | foo.trimLeft()
+      1 | foo?.trimLeft()
 
 > Output
 
     `␊
-      1 | foo.trimStart()␊
+      1 | foo?.trimStart()␊
     `
 
 > Error 1/1
 
     `␊
-    > 1 | foo.trimLeft()␊
-        |     ^^^^^^^^ Prefer \`String#trimStart()\` over \`String#trimLeft()\`.␊
+    > 1 | foo?.trimLeft()␊
+        |      ^^^^^^^^ Prefer \`String#trimStart()\` over \`String#trimLeft()\`.␊
     `
diff --git a/test/snapshots/prefer-string-trim-start-end.mjs.snap b/test/snapshots/prefer-string-trim-start-end.mjs.snap