prefer-node-protocol: Always check require() (#1827)

docs/rules/prefer-node-protocol.md

@@ -25,6 +25,10 @@ export {strict as default} from 'assert';
 import fs from 'fs/promises';
 ```
 
+```js
+const fs = require('fs/promises');
+```
+
 ## Pass
 
 ```js
@@ -51,20 +55,6 @@ import _ from 'lodash';
 import fs from './fs.js';
 ```
 
-## Options
-
-Type: `object`
-
-### `checkRequire`
-
-Type: `boolean`\
-Default: `false`
-
-Currently, `require(…)` with the `node:` protocol is only available on Node.js 16. If you don't care about old versions, you can set this to `true`.
-
-We'll remove this option and check `require(…)` by default once this feature get backported to v12.
-
 ```js
-// eslint unicorn/prefer-node-protocol: ["error", {"checkRequire": true}]
-const fs = require('fs'); // Fails
+const fs = require('node:fs/promises');
 ```

package.json

@@ -11,7 +11,7 @@
 		"url": "https://sindresorhus.com"
 	},
 	"engines": {
-		"node": ">=14"
+		"node": ">=14.18"
 	},
 	"scripts": {
 		"create-rule": "node ./scripts/create-rule.mjs && npm run generate-rule-notices && npm run generate-rules-table",

rules/filename-case.js

@@ -1,5 +1,5 @@
 'use strict';
-const path = require('path');
+const path = require('node:path');
 const {camelCase, kebabCase, snakeCase, upperFirst} = require('lodash');
 const cartesianProductSamples = require('./utils/cartesian-product-samples.js');
 

rules/prefer-node-protocol.js

@@ -14,51 +14,31 @@ const importExportSourceSelector = [
 	'Literal.source',
 ].join('');
 
-/** @param {import('eslint').Rule.RuleContext} context */
-const create = context => {
-	const {checkRequire} = {
-		checkRequire: false,
-		...context.options[0],
-	};
-	const selectors = [importExportSourceSelector];
-	if (checkRequire) {
-		selectors.push(STATIC_REQUIRE_SOURCE_SELECTOR);
-	}
+const selector = matches([
+	importExportSourceSelector,
+	STATIC_REQUIRE_SOURCE_SELECTOR,
+]);
 
-	return {
-		[matches(selectors)](node) {
-			const {value} = node;
-			if (
-				typeof value !== 'string'
-				|| value.startsWith('node:')
-				|| !isBuiltinModule(value)
-			) {
-				return;
-			}
+const create = () => ({
+	[selector](node) {
+		const {value} = node;
+		if (
+			typeof value !== 'string'
+			|| value.startsWith('node:')
+			|| !isBuiltinModule(value)
+		) {
+			return;
+		}
 
-			return {
-				node,
-				messageId: MESSAGE_ID,
-				data: {moduleName: value},
-				/** @param {import('eslint').Rule.RuleFixer} fixer */
-				fix: fixer => replaceStringLiteral(fixer, node, 'node:', 0, 0),
-			};
-		},
-	};
-};
-
-const schema = [
-	{
-		type: 'object',
-		additionalProperties: false,
-		properties: {
-			checkRequire: {
-				type: 'boolean',
-				default: false,
-			},
-		},
+		return {
+			node,
+			messageId: MESSAGE_ID,
+			data: {moduleName: value},
+			/** @param {import('eslint').Rule.RuleFixer} fixer */
+			fix: fixer => replaceStringLiteral(fixer, node, 'node:', 0, 0),
+		};
 	},
-];
+});
 
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
@@ -69,7 +49,6 @@ module.exports = {
 			description: 'Prefer using the `node:` protocol when importing Node.js builtin modules.',
 		},
 		fixable: 'code',
-		schema,
 		messages,
 	},
 };

rules/prevent-abbreviations.js

@@ -1,5 +1,5 @@
 'use strict';
-const path = require('path');
+const path = require('node:path');
 const {defaultsDeep, upperFirst, lowerFirst} = require('lodash');
 
 const avoidCapture = require('./utils/avoid-capture.js');

rules/utils/get-documentation-url.js

@@ -1,5 +1,5 @@
 'use strict';
-const path = require('path');
+const path = require('node:path');
 const packageJson = require('../../package.json');
 
 const repoUrl = 'https://github.com/sindresorhus/eslint-plugin-unicorn';

rules/utils/rule.js

@@ -1,6 +1,6 @@
 'use strict';
-const path = require('path');
-const fs = require('fs');
+const path = require('node:path');
+const fs = require('node:fs');
 const getDocumentationUrl = require('./get-documentation-url.js');
 
 const isIterable = object => typeof object[Symbol.iterator] === 'function';

scripts/internal-rules/prefer-disallow-over-forbid.js

@@ -1,5 +1,5 @@
 'use strict';
-const path = require('path');
+const path = require('node:path');
 const {matches} = require('../../rules/selectors/index.js');
 const toLocation = require('../../rules/utils/to-location.js');
 

scripts/internal-rules/prefer-negative-boolean-attribute.js

@@ -1,5 +1,5 @@
 'use strict';
-const path = require('path');
+const path = require('node:path');
 
 const messageId = path.basename(__filename, '.js');
 

test/prefer-node-protocol.mjs

@@ -8,7 +8,6 @@ test.snapshot({
 		'import unicorn from "unicorn";',
 		'import fs from "./fs";',
 		'import fs from "unknown-builtin-module";',
-		'const fs = require("fs");',
 		'import fs from "node:fs";',
 		outdent`
 			async function foo() {
@@ -60,8 +59,7 @@ test.snapshot({
 	],
 });
 
-// `options`
-const checkRequireOptions = [{checkRequire: true}];
+// `require`
 test.snapshot({
 	valid: [
 		'const fs = require("node:fs");',
@@ -76,11 +74,11 @@ test.snapshot({
 		'const fs = require();',
 		'const fs = require(...["fs"]);',
 		'const fs = require("unicorn");',
-	].map(code => ({code, options: checkRequireOptions})),
+	],
 	invalid: [
 		'const {promises} = require("fs")',
 		'const fs = require(\'fs/promises\')',
-	].map(code => ({code, options: checkRequireOptions})),
+	],
 });
 
 test.babel({

test/snapshots/prefer-node-protocol.mjs.md

@@ -255,16 +255,6 @@ Generated by [AVA](https://avajs.dev).
 ## Invalid #1
       1 | const {promises} = require("fs")
 
-> Options
-
-    `␊
-    [␊
-      {␊
-        "checkRequire": true␊
-      }␊
-    ]␊
-    `
-
 > Output
 
     `␊
@@ -281,16 +271,6 @@ Generated by [AVA](https://avajs.dev).
 ## Invalid #2
       1 | const fs = require('fs/promises')
 
-> Options
-
-    `␊
-    [␊
-      {␊
-        "checkRequire": true␊
-      }␊
-    ]␊
-    `
-
 > Output
 
     `␊