prefer-query-selector: Fix crash on calling without argument (#906)

sindresorhus · Nov 24, 2020 · 36908da · 36908da
1 parent 8335d41
commit 36908da
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/rules/prefer-query-selector.js b/rules/prefer-query-selector.js
@@ -105,6 +105,11 @@ const create = context => {
 				return;
 			}
 
+			const [firstArgument] = node.arguments;
+			if (node.arguments.length !== 1 || firstArgument.type === 'SpreadElement') {
+				return;
+			}
+
 			const report = {
 				node,
 				messageId: MESSAGE_ID,

diff --git a/test/prefer-query-selector.js b/test/prefer-query-selector.js
@@ -7,6 +7,11 @@ const createError = (method, replacement) => ({
 
 test({
 	valid: [
+		// More or less arguments
+		'document.getElementById();',
+		'document.getElementsByClassName("foo", "bar");',
+		'document.getElementById(...["id"]);',
+
 		'document.querySelector("#foo");',
 		'document.querySelector(".bar");',
 		'document.querySelector("main #foo .bar");',