no-array-callback-reference: Only ignore Boolean in reasonable pl…

…aces (#1570)
sindresorhus · Nov 2, 2021 · 46f8638 · 46f8638
1 parent 15f9028
commit 46f8638
Show file tree

Hide file tree

Showing 2 changed files with 65 additions and 13 deletions.
diff --git a/rules/no-array-callback-reference.js b/rules/no-array-callback-reference.js
@@ -15,54 +15,96 @@ const messages = {
 };
 
 const iteratorMethods = [
-	['every'],
+	[
+		'every',
+		{
+			ignore: [
+				'Boolean',
+			],
+		},
+	],
 	[
 		'filter', {
 			extraSelector: '[callee.object.name!="Vue"]',
+			ignore: [
+				'Boolean',
+			],
+		},
+	],
+	[
+		'find',
+		{
+			ignore: [
+				'Boolean',
+			],
+		},
+	],
+	[
+		'findIndex',
+		{
+			ignore: [
+				'Boolean',
+			],
+		},
+	],
+	[
+		'flatMap',
+		{
+			ignore: [
+				'Boolean',
+			],
 		},
 	],
-	['find'],
-	['findIndex'],
-	['flatMap'],
 	[
 		'forEach', {
 			returnsUndefined: true,
 		},
 	],
 	[
-		'map', {
+		'map',
+		{
 			extraSelector: '[callee.object.name!="types"]',
+			ignore: [
+				'Boolean',
+			],
 		},
 	],
 	[
-		'reduce', {
+		'reduce',
+		{
 			parameters: [
 				'accumulator',
 				'element',
 				'index',
 				'array',
 			],
 			minParameters: 2,
-			ignore: [],
 		},
 	],
 	[
-		'reduceRight', {
+		'reduceRight',
+		{
 			parameters: [
 				'accumulator',
 				'element',
 				'index',
 				'array',
 			],
 			minParameters: 2,
-			ignore: [],
 		},
 	],
-	['some'],
+	[
+		'some',
+		{
+			ignore: [
+				'Boolean',
+			],
+		},
+	],
 ].map(([method, options]) => {
 	options = {
 		parameters: ['element', 'index', 'array'],
-		ignore: ['Boolean'],
+		ignore: [],
 		minParameters: 1,
 		extraSelector: '',
 		returnsUndefined: false,

diff --git a/test/no-array-callback-reference.mjs b/test/no-array-callback-reference.mjs
@@ -57,7 +57,7 @@ test({
 		...reduceLikeMethods.map(method => `this.${method}(fn)`),
 
 		// `Boolean`
-		...simpleMethods.map(method => `foo.${method}(Boolean)`),
+		'foo.map(Boolean)',
 
 		// Not `CallExpression`
 		'new foo.map(fn);',
@@ -207,7 +207,7 @@ test({
 			}),
 		),
 
-		// `Boolean` is not ignored on `reduce` and `reduceRight`
+		// `Boolean` is only ignored on reasonable places
 		...reduceLikeMethods.map(
 			method => invalidTestCase({
 				code: `foo.${method}(Boolean, initialValue)`,
@@ -220,6 +220,16 @@ test({
 				],
 			}),
 		),
+		invalidTestCase({
+			code: 'foo.forEach(Boolean)',
+			method: 'forEach',
+			name: 'Boolean',
+			suggestions: [
+				'foo.forEach((element) => { Boolean(element); })',
+				'foo.forEach((element, index) => { Boolean(element, index); })',
+				'foo.forEach((element, index, array) => { Boolean(element, index, array); })',
+			],
+		}),
 
 		// Not `Identifier`
 		...simpleMethodsExceptForEach.map(