no-array-for-each: Fix auto-fix causing SyntaxError (#1813)

Co-authored-by: fisker Cheung <lionkay@gmail.com>
sindresorhus · May 17, 2022 · 47c8337 · 47c8337
1 parent 166524a
commit 47c8337
Show file tree

Hide file tree

Showing 4 changed files with 227 additions and 204 deletions.
diff --git a/rules/no-array-for-each.js b/rules/no-array-for-each.js
@@ -361,6 +361,8 @@ function isFixable(callExpression, {scope, functionInfo, allIdentifiers, context
 	const parameters = callback.params;
 	if (
 		!(parameters.length === 1 || parameters.length === 2)
+		// `array.forEach((element = defaultValue) => {})`
+		|| (parameters.length === 1 && parameters[0].type === 'AssignmentPattern')
 		|| parameters.some(({type, typeAnnotation}) => type === 'RestElement' || typeAnnotation)
 		|| !isFunctionParametersSafeToFix(callback, {scope, callExpression, allIdentifiers, context})
 	) {

diff --git a/test/no-array-for-each.mjs b/test/no-array-for-each.mjs
@@ -34,6 +34,7 @@ test.snapshot({
 			'foo.forEach((element, index, array) => bar())',
 			'property.forEach(({property}) => bar(property))',
 			'() => foo.forEach()',
+			'foo.forEach((element = {}) => call(element))',
 
 			// Can't turn `return` to `continue`
 			outdent`