no-empty-file: Fix false positive with triple-slash directives (#1605)

sindresorhus · Nov 15, 2021 · 6354bb8 · 6354bb8
1 parent 426f01a
commit 6354bb8
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/rules/no-empty-file.js b/rules/no-empty-file.js
@@ -13,6 +13,12 @@ const isEmpty = node =>
 	|| node.type === 'EmptyStatement'
 	|| (node.type === 'ExpressionStatement' && 'directive' in node);
 
+const isTripleSlashDirective = node =>
+	node.type === 'Line' && node.value.startsWith('/');
+
+const hasTripeSlashDirectives = comments =>
+	comments.some(currentNode => isTripleSlashDirective(currentNode));
+
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
 	const filename = context.getPhysicalFilename().toLowerCase();
@@ -27,6 +33,13 @@ const create = context => {
 				return;
 			}
 
+			const sourceCode = context.getSourceCode();
+			const comments = sourceCode.getAllComments();
+
+			if (hasTripeSlashDirectives(comments)) {
+				return;
+			}
+
 			return {
 				node,
 				messageId: MESSAGE_ID,

diff --git a/test/no-empty-file.mjs b/test/no-empty-file.mjs
@@ -37,6 +37,10 @@ test.snapshot({
 			'svelte',
 			'tsx',
 		].map(extension => ({code: '', filename: `example.${extension}`})),
+		...[
+			'd.ts',
+			'ts',
+		].map(extension => ({code: '/// <reference types="example" />', filename: `example.${extension}`})),
 	],
 	invalid: [
 		...[