prevent-abbreviations: Fix optional parameter (#764)

sindresorhus · Jun 2, 2020 · 7781c3f · 7781c3f
1 parent 56f6e76
commit 7781c3f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/rules/utils/rename-identifier.js b/rules/utils/rename-identifier.js
@@ -28,7 +28,7 @@ function renameIdentifier(identifier, name, fixer, sourceCode) {
 
 	// `typeAnnotation`
 	if (identifier.typeAnnotation) {
-		return fixer.replaceText(identifier, `${name}${sourceCode.getText(identifier.typeAnnotation)}`);
+		return fixer.replaceText(identifier, `${name}${identifier.optional ? '?' : ''}${sourceCode.getText(identifier.typeAnnotation)}`);
 	}
 
 	return fixer.replaceText(identifier, name);

diff --git a/test/prevent-abbreviations.js b/test/prevent-abbreviations.js
@@ -1720,6 +1720,13 @@ typescriptRuleTester.run('prevent-abbreviations', rule, {
 			code,
 			output: code.replace('prop', 'property'),
 			errors: createErrors()
-		}))
+		})),
+
+		// #763
+		{
+			code: 'const foo = (extraParams?: string) => {}',
+			output: 'const foo = (extraParameters?: string) => {}',
+			errors: createErrors()
+		}
 	]
 });