no-array-callback-reference: Ignore jQuery methods (#1457)

sindresorhus · Aug 2, 2021 · 7af9a6f · 7af9a6f
1 parent 153eb2c
commit 7af9a6f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/rules/no-array-callback-reference.js b/rules/no-array-callback-reference.js
@@ -82,6 +82,8 @@ const ignoredCallee = [
 	'Async',
 	'async',
 	'this',
+	'$',
+	'jQuery',
 ];
 
 function getProblem(context, node, method, options) {
@@ -164,6 +166,10 @@ const create = context => {
 				return;
 			}
 
+			if (node.callee.object.type === 'CallExpression' && isNodeMatches(node.callee.object.callee, ignoredCallee)) {
+				return;
+			}
+
 			const [iterator] = node.arguments;
 			return getProblem(context, iterator, method, options, sourceCode);
 		};

diff --git a/test/no-array-callback-reference.mjs b/test/no-array-callback-reference.mjs
@@ -86,6 +86,14 @@ test({
 		'Children.forEach(children, fn)', // `import {Children} from 'react';`
 		'Vue.filter(name, fn)',
 
+		// #1376
+		'$(this).find(tooltip)',
+		'$.map(realArray, function(value, index) {});',
+		'$(this).filter(tooltip)',
+		'jQuery(this).find(tooltip)',
+		'jQuery.map(realArray, function(value, index) {});',
+		'jQuery(this).filter(tooltip)',
+
 		// First argument is not a function
 		...notFunctionTypes.map(data => `foo.map(${data})`),