prefer-add-event-listener: Remove fix for onerror (#1650)

sindresorhus · Dec 23, 2021 · 7bf63bb · 7bf63bb
1 parent 10ad699
commit 7bf63bb
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 61 deletions.
diff --git a/rules/prefer-add-event-listener.js b/rules/prefer-add-event-listener.js
@@ -10,6 +10,7 @@ const messages = {
 const extraMessages = {
 	beforeunload: 'Use `event.preventDefault(); event.returnValue = \'foo\'` to trigger the prompt.',
 	message: 'Note that there is difference between `SharedWorker#onmessage` and `SharedWorker#addEventListener(\'message\')`.',
+	error: 'Note that there is difference between `{window,element}.onerror` and `{window,element}.addEventListener(\'error\')`.',
 };
 
 const getEventMethodName = memberExpression => memberExpression.property.name;
@@ -137,6 +138,9 @@ const create = context => {
 			} else if (eventTypeName === 'message') {
 				// Disable `onmessage` fix, see #537
 				extra = extraMessages.message;
+			} else if (eventTypeName === 'error') {
+				// Disable `onerror` fix, see #1493
+				extra = extraMessages.error;
 			} else {
 				fix = fixer => fixCode(fixer, context.getSourceCode(), node, memberExpression);
 			}

diff --git a/test/snapshots/prefer-add-event-listener.mjs.md b/test/snapshots/prefer-add-event-listener.mjs.md
@@ -287,43 +287,27 @@ Generated by [AVA](https://avajs.dev).
       2 |
       3 | foo.onerror = () => {};
 
-> Output
-
-    `␊
-      1 | const foo = require('foo');␊
-      2 |␊
-      3 | foo.addEventListener('error', () => {});␊
-    `
-
 > Error 1/1
 
     `␊
       1 | const foo = require('foo');␊
       2 |␊
     > 3 | foo.onerror = () => {};␊
-        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`.␊
+        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`. Note that there is difference between \`{window,element}.onerror\` and \`{window,element}.addEventListener('error')\`.␊
     `
 
 ## Invalid #20
       1 | import foo from 'foo';
       2 |
       3 | foo.onerror = () => {};
 
-> Output
-
-    `␊
-      1 | import foo from 'foo';␊
-      2 |␊
-      3 | foo.addEventListener('error', () => {});␊
-    `
-
 > Error 1/1
 
     `␊
       1 | import foo from 'foo';␊
       2 |␊
     > 3 | foo.onerror = () => {};␊
-        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`.␊
+        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`. Note that there is difference between \`{window,element}.onerror\` and \`{window,element}.addEventListener('error')\`.␊
     `
 
 ## Invalid #21
@@ -335,23 +319,11 @@ Generated by [AVA](https://avajs.dev).
       6 | 	koa.onerror = () => {};
       7 | }
 
-> Output
-
-    `␊
-      1 | foo.addEventListener('error', () => {});␊
-      2 |␊
-      3 | function bar() {␊
-      4 | 	const koa = require('koa');␊
-      5 |␊
-      6 | 	koa.onerror = () => {};␊
-      7 | }␊
-    `
-
 > Error 1/1
 
     `␊
     > 1 | foo.onerror = () => {};␊
-        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`.␊
+        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`. Note that there is difference between \`{window,element}.onerror\` and \`{window,element}.addEventListener('error')\`.␊
       2 |␊
       3 | function bar() {␊
       4 | 	const koa = require('koa');␊
@@ -378,23 +350,14 @@ Generated by [AVA](https://avajs.dev).
     ]␊
     `
 
-> Output
-
-    `␊
-      1 | const Koa = require('koa');␊
-      2 | const app = new Koa();␊
-      3 |␊
-      4 | app.addEventListener('error', () => {});␊
-    `
-
 > Error 1/1
 
     `␊
       1 | const Koa = require('koa');␊
       2 | const app = new Koa();␊
       3 |␊
     > 4 | app.onerror = () => {};␊
-        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`.␊
+        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`. Note that there is difference between \`{window,element}.onerror\` and \`{window,element}.addEventListener('error')\`.␊
     `
 
 ## Invalid #23
@@ -415,23 +378,14 @@ Generated by [AVA](https://avajs.dev).
     ]␊
     `
 
-> Output
-
-    `␊
-      1 | import {Koa as Foo} from 'koa';␊
-      2 | const app = new Foo();␊
-      3 |␊
-      4 | app.addEventListener('error', () => {});␊
-    `
-
 > Error 1/1
 
     `␊
       1 | import {Koa as Foo} from 'koa';␊
       2 | const app = new Foo();␊
       3 |␊
     > 4 | app.onerror = () => {};␊
-        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`.␊
+        |     ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`. Note that there is difference between \`{window,element}.onerror\` and \`{window,element}.addEventListener('error')\`.␊
     `
 
 ## Invalid #24
@@ -452,23 +406,14 @@ Generated by [AVA](https://avajs.dev).
     ]␊
     `
 
-> Output
-
-    `␊
-      1 | const sax = require('sax');␊
-      2 | const parser = sax.parser();␊
-      3 |␊
-      4 | parser.addEventListener('error', () => {});␊
-    `
-
 > Error 1/1
 
     `␊
       1 | const sax = require('sax');␊
       2 | const parser = sax.parser();␊
       3 |␊
     > 4 | parser.onerror = () => {};␊
-        |        ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`.␊
+        |        ^^^^^^^ Prefer \`addEventListener\` over \`onerror\`. Note that there is difference between \`{window,element}.onerror\` and \`{window,element}.addEventListener('error')\`.␊
     `
 
 ## Invalid #25

diff --git a/test/snapshots/prefer-add-event-listener.mjs.snap b/test/snapshots/prefer-add-event-listener.mjs.snap