no-useless-undefined: Ignore Array#includes() and Set#has() (#1951

)
sindresorhus · Nov 7, 2022 · 8dfd5a7 · 8dfd5a7
1 parent 00a29c8
commit 8dfd5a7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/rules/no-useless-undefined.js b/rules/no-useless-undefined.js
@@ -69,18 +69,26 @@ const shouldIgnore = node => {
 	}
 
 	return compareFunctionNames.has(name)
-		// https://vuejs.org/api/reactivity-core.html#ref
-		|| name === 'ref'
-		// `set.add(undefined)`
-		|| name === 'add'
-		// `map.set(foo, undefined)`
-		|| name === 'set'
 		// `array.push(undefined)`
 		|| name === 'push'
 		// `array.unshift(undefined)`
 		|| name === 'unshift'
+		// `array.includes(undefined)`
+		|| name === 'includes'
+
+		// `set.add(undefined)`
+		|| name === 'add'
+		// `set.has(undefined)`
+		|| name === 'has'
+
+		// `map.set(foo, undefined)`
+		|| name === 'set'
+
 		// `React.createContext(undefined)`
-		|| name === 'createContext';
+		|| name === 'createContext'
+
+		// https://vuejs.org/api/reactivity-core.html#ref
+		|| name === 'ref';
 };
 
 const getFunction = scope => {

diff --git a/test/no-useless-undefined.mjs b/test/no-useless-undefined.mjs
@@ -53,6 +53,8 @@ test({
 		'array.unshift(undefined);',
 		'createContext(undefined);',
 		'React.createContext(undefined);',
+		'array.includes(undefined)',
+		'set.has(undefined)',
 
 		// `Function#bind()`
 		'foo.bind(bar, undefined)',