From 8dfd5a718db3c4569411ac00416c530c41de14ab Mon Sep 17 00:00:00 2001 From: fisker Cheung Date: Mon, 7 Nov 2022 21:53:55 +0800 Subject: [PATCH] `no-useless-undefined`: Ignore `Array#includes()` and `Set#has()` (#1951) --- rules/no-useless-undefined.js | 22 +++++++++++++++------- test/no-useless-undefined.mjs | 2 ++ 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/rules/no-useless-undefined.js b/rules/no-useless-undefined.js index 5579442a3a..1f901167a2 100644 --- a/rules/no-useless-undefined.js +++ b/rules/no-useless-undefined.js @@ -69,18 +69,26 @@ const shouldIgnore = node => { } return compareFunctionNames.has(name) - // https://vuejs.org/api/reactivity-core.html#ref - || name === 'ref' - // `set.add(undefined)` - || name === 'add' - // `map.set(foo, undefined)` - || name === 'set' // `array.push(undefined)` || name === 'push' // `array.unshift(undefined)` || name === 'unshift' + // `array.includes(undefined)` + || name === 'includes' + + // `set.add(undefined)` + || name === 'add' + // `set.has(undefined)` + || name === 'has' + + // `map.set(foo, undefined)` + || name === 'set' + // `React.createContext(undefined)` - || name === 'createContext'; + || name === 'createContext' + + // https://vuejs.org/api/reactivity-core.html#ref + || name === 'ref'; }; const getFunction = scope => { diff --git a/test/no-useless-undefined.mjs b/test/no-useless-undefined.mjs index ed06d515d4..0901e83230 100644 --- a/test/no-useless-undefined.mjs +++ b/test/no-useless-undefined.mjs @@ -53,6 +53,8 @@ test({ 'array.unshift(undefined);', 'createContext(undefined);', 'React.createContext(undefined);', + 'array.includes(undefined)', + 'set.has(undefined)', // `Function#bind()` 'foo.bind(bar, undefined)',