Skip to content

Commit 8f61f7c

Browse files
ST-DDTfisker
andauthoredNov 27, 2023
prefer-module: Allow module as TSTypeParameter name (#2213)
Co-authored-by: fisker Cheung <lionkay@gmail.com>
1 parent b95e75e commit 8f61f7c

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed
 

‎rules/ast/is-reference-identifier.js

+5
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,11 @@ function isNotReference(node) {
120120
return parent.parameters.includes(node);
121121
}
122122

123+
// `type Foo = { [Identifier in keyof string]: number; };`
124+
case 'TSTypeParameter': {
125+
return parent.name === node;
126+
}
127+
123128
// `type Identifier = Foo`
124129
case 'TSTypeAliasDeclaration': {
125130
return parent.id === node;

‎test/prefer-module.mjs

+1
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ test.typescript({
272272
'type ModuleRegistry = { [module: string]: string };',
273273
'const module = 1; type ModuleRegistry = { [module: string]: string };',
274274
'type module = number[]; type ModuleRegistry = { [module: string]: string };',
275+
'type Data = { [module in keyof string]: number; };',
275276
'type ModuleRegistry = { [exports: string]: string };',
276277
],
277278
invalid: [],

0 commit comments

Comments
 (0)
Please sign in to comment.