consistent-destructuring: Add ExperimentalRestProperty check (#1060)

sindresorhus · Jan 24, 2021 · aca2ec5 · aca2ec5
1 parent 75c477f
commit aca2ec5
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 11 deletions.
diff --git a/rules/consistent-destructuring.js b/rules/consistent-destructuring.js
@@ -92,7 +92,10 @@ const create = context => {
 				property.value.type === 'Identifier'
 			);
 			const lastProperty = objectPattern.properties[objectPattern.properties.length - 1];
-			const hasRest = lastProperty && lastProperty.type === 'RestElement';
+
+			// TODO: Remove `ExperimentalRestProperty` check when we drop support for `babel-eslint` #1040
+			const hasRest = lastProperty &&
+				(lastProperty.type === 'RestElement' || lastProperty.type === 'ExperimentalRestProperty');
 
 			const expression = source.getText(node);
 			const member = source.getText(node.property);

diff --git a/test/consistent-destructuring.js b/test/consistent-destructuring.js
@@ -1,13 +1,5 @@
-import test from 'ava';
-import avaRuleTester from 'eslint-ava-rule-tester';
 import {outdent} from 'outdent';
-import rule from '../rules/consistent-destructuring.js';
-
-const ruleTester = avaRuleTester(test, {
-	parserOptions: {
-		ecmaVersion: 2020
-	}
-});
+import {test} from './utils/test.js';
 
 const invalidTestCase = ({code, suggestions}) => {
 	if (!suggestions) {
@@ -33,7 +25,7 @@ const invalidTestCase = ({code, suggestions}) => {
 	};
 };
 
-ruleTester.run('consistent-destructuring', rule, {
+test({
 	valid: [
 		'console.log(foo.a, foo.b);',
 		'const foo = 10;',
@@ -476,3 +468,24 @@ ruleTester.run('consistent-destructuring', rule, {
 		}
 	]
 });
+
+test.babelLegacy({
+	valid: [
+		outdent`
+			const {a, ...b} = bar;
+			console.log(bar.c);
+		`
+	],
+	invalid: [
+		invalidTestCase({
+			code: outdent`
+				const {a, ...b} = bar;
+				console.log(bar.a);
+			`,
+			suggestions: [outdent`
+				const {a, ...b} = bar;
+				console.log(a);
+			`]
+		})
+	]
+});