prefer-replace-all: Handle u flag (#879)

sindresorhus · Oct 20, 2020 · d98d867 · d98d867
1 parent d10a641
commit d98d867
Show file tree

Hide file tree

Showing 5 changed files with 68 additions and 1 deletion.
diff --git a/docs/rules/prefer-replace-all.md b/docs/rules/prefer-replace-all.md
@@ -8,14 +8,30 @@ This rule is fixable.
 
 ```js
 string.replace(/This has no special regex symbols/g, '');
+```
+
+```js
 string.replace(/\(It also checks for escaped regex symbols\)/g, '');
 ```
 
+```js
+string.replace(/Works for u flag too/gu, '');
+```
+
 ## Pass
 
 ```js
 string.replace(/Non-literal characters .*/g, '');
+```
+
+```js
 string.replace(/Extra flags/gi, '');
+```
+
+```js
 string.replace('Not a regex expression', '')
+```
+
+```js
 string.replaceAll('Literal characters only', '');
 ```
diff --git a/rules/prefer-replace-all.js b/rules/prefer-replace-all.js
@@ -15,7 +15,12 @@ const selector = methodSelector({
 
 function isRegexWithGlobalFlag(node) {
 	const {type, regex} = node;
-	return type === 'Literal' && regex && regex.flags === 'g';
+	if (type !== 'Literal' || !regex) {
+		return false;
+	}
+
+	const {flags} = regex;
+	return flags.replace('u', '') === 'g';
 }
 
 function isLiteralCharactersOnly(node) {

diff --git a/test/prefer-replace-all.js b/test/prefer-replace-all.js
@@ -13,8 +13,12 @@ test({
 		'foo.replace(/a?/g, bar)',
 		'foo.replace(/.*/g, bar)',
 		'foo.replace(/\\W/g, bar)',
+		'foo.replace(/\\u{61}/g, bar)',
+		'foo.replace(/\\u{61}/gu, bar)',
 		// Extra flag
 		'foo.replace(/a/gi, bar)',
+		'foo.replace(/a/gui, bar)',
+		'foo.replace(/a/uig, bar)',
 		// Not regex literal
 		'foo.replace(\'string\', bar)',
 		// Not 2 arguments
@@ -82,3 +86,8 @@ test({
 		}
 	]
 });
+
+test.visualize([
+	'foo.replace(/a/gu, bar)',
+	'foo.replace(/a/ug, bar)'
+]);
diff --git a/test/snapshots/prefer-replace-all.js.md b/test/snapshots/prefer-replace-all.js.md
@@ -0,0 +1,37 @@
+# Snapshot report for `test/prefer-replace-all.js`
+
+The actual snapshot is saved in `prefer-replace-all.js.snap`.
+
+Generated by [AVA](https://avajs.dev).
+
+## prefer-replace-all - #1
+
+> Snapshot 1
+
+    `␊
+    Input:␊
+      1 | foo.replace(/a/gu, bar)␊
+    ␊
+    Output:␊
+      1 | foo.replaceAll('a', bar)␊
+    ␊
+    Error 1/1:␊
+    > 1 | foo.replace(/a/gu, bar)␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^ Prefer `String#replaceAll()` over `String#replace()`.␊
+    `
+
+## prefer-replace-all - #2
+
+> Snapshot 1
+
+    `␊
+    Input:␊
+      1 | foo.replace(/a/ug, bar)␊
+    ␊
+    Output:␊
+      1 | foo.replaceAll('a', bar)␊
+    ␊
+    Error 1/1:␊
+    > 1 | foo.replace(/a/ug, bar)␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^ Prefer `String#replaceAll()` over `String#replace()`.␊
+    `
diff --git a/test/snapshots/prefer-replace-all.js.snap b/test/snapshots/prefer-replace-all.js.snap