prefer-spread: Ignore Buffer.concat() (#1069)

rules/prefer-spread.js

@@ -38,9 +38,13 @@ const arrayConcatCallSelector = [
 	}),
 	`:not(${
 		[
-			'Literal',
-			'TemplateLiteral'
-		].map(type => `[callee.object.type="${type}"]`).join(', ')
+			...[
+				'Literal',
+				'TemplateLiteral'
+			].map(type => `[callee.object.type="${type}"]`),
+			// Most likely it's a static method of a class
+			'[callee.object.name=/^[A-Z]/]'
+		].join(', ')
 	})`
 ].join('');
 

test/prefer-spread.js

@@ -146,7 +146,13 @@ test.snapshot({
 		outdent`
 			const string = 'foo';
 			foo = string.concat("bar");
-		`
+		`,
+		// #1068
+		'const bufA = Buffer.concat([buf1, buf2, buf3], totalLength);',
+		'Foo.concat(1)',
+		'FooBar.concat(1)',
+		'FOO.concat(1)',
+		'A.concat(1)'
 	],
 	invalid: [
 		'[1].concat(2)',
@@ -229,6 +235,8 @@ test.snapshot({
 		'[].concat((a.b.c), 2)',
 		'[].concat(a.b(), 2)',
 		'foo.concat(bar, 2, [3, 4], baz, 5, [6, 7])',
-		'foo.concat(bar, 2, 3, ...baz)'
+		'foo.concat(bar, 2, 3, ...baz)',
+		'notClass.concat(1)',
+		'_A.concat(1)'
 	]
 });

test/snapshots/prefer-spread.js.md

@@ -1374,3 +1374,35 @@ Generated by [AVA](https://avajs.dev).
     Suggestion 3/3: Test first argument with `Array.isArray(…)`.␊
       1 | [...foo, ...(Array.isArray(bar) ? bar : [bar]), 2, 3].concat(...baz)␊
     `
+
+## Invalid #52
+      1 | notClass.concat(1)
+
+> Output
+
+    `␊
+      1 | [...notClass, 1]␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | notClass.concat(1)␊
+        |          ^^^^^^ Prefer the spread operator over `Array#concat(…)`.␊
+    `
+
+## Invalid #53
+      1 | _A.concat(1)
+
+> Output
+
+    `␊
+      1 | [..._A, 1]␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | _A.concat(1)␊
+        |    ^^^^^^ Prefer the spread operator over `Array#concat(…)`.␊
+    `