prefer-export-from: Ignore variables with type (#1580)

sindresorhus · Nov 8, 2021 · ea49b21 · ea49b21
1 parent 5625dab
commit ea49b21
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/rules/prefer-export-from.js b/rules/prefer-export-from.js
@@ -157,6 +157,7 @@ function getExported(identifier, context) {
 			if (
 				parent.init === identifier
 				&& parent.id.type === 'Identifier'
+				&& !parent.id.typeAnnotation
 				&& parent.parent.type === 'VariableDeclaration'
 				&& parent.parent.kind === 'const'
 				&& parent.parent.declarations.length === 1

diff --git a/test/prefer-export-from.mjs b/test/prefer-export-from.mjs
@@ -285,3 +285,16 @@ test.snapshot({
 		`,
 	],
 });
+
+test.typescript({
+	valid: [
+		// #1579
+		outdent`
+			import {useDispatch as reduxUseDispatch} from 'react-redux'
+			type MyDispatchType = Dispatch<MyActions>
+
+			export const useDispatch: () => DispatchAllActions = reduxUseDispatch
+		`,
+	],
+	invalid: [],
+});