Fix expiring-todo-comments crashing on invalid package version (#494)

sindresorhus · Jan 21, 2020 · fd46adc · fd46adc
1 parent b1d3f37
commit fd46adc
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/rules/expiring-todo-comments.js b/rules/expiring-todo-comments.js
@@ -159,7 +159,11 @@ function reachedDate(past) {
 }
 
 function tryToCoerceVersion(rawVersion) {
-	let version = rawVersion;
+	if (!rawVersion) {
+		return false;
+	}
+
+	let version = String(rawVersion);
 
 	// Remove leading things like `^1.0.0`, `>1.0.0`
 	const leadingNoises = [
@@ -312,10 +316,10 @@ const create = context => {
 			const [{condition, version}] = packageVersions;
 
 			const packageVersion = tryToCoerceVersion(packageJson.version);
-			const desidedPackageVersion = tryToCoerceVersion(version);
+			const decidedPackageVersion = tryToCoerceVersion(version);
 
 			const compare = semverComparisonForOperator(condition);
-			if (compare(packageVersion, desidedPackageVersion)) {
+			if (packageVersion && compare(packageVersion, decidedPackageVersion)) {
 				context.report({
 					node: null,
 					loc: comment.loc,