Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-array-push-push rule #1015

Merged
merged 10 commits into from Jan 14, 2021
Merged

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jan 13, 2021

Part of #937, only work for .push()

@fisker fisker marked this pull request as ready for review January 13, 2021 08:06
rules/no-array-push-push.js Outdated Show resolved Hide resolved
docs/rules/no-array-push-push.md Outdated Show resolved Hide resolved
docs/rules/no-array-push-push.md Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Not sure about the rule name. How about no-multiple-array-push?

@fisker
Copy link
Collaborator Author

fisker commented Jan 14, 2021

I like no-array-push-push, like core rule no-plusplus.

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus
Copy link
Owner

Ok. Sure. I don't feel strongly about it.

@sindresorhus sindresorhus merged commit 21537d7 into sindresorhus:master Jan 14, 2021
@fisker fisker deleted the no-array-push-push branch January 14, 2021 10:10
@fisker
Copy link
Collaborator Author

fisker commented Jan 14, 2021

#1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants