Add no-array-for-each rule
#1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
Jan 14, 2021
rules/no-array-for-each.js
Outdated
| return false; | ||
| } | ||
|
|
||
| // TODO: check parameters conflicts |
There was a problem hiding this comment.
Not really sure how to check this,
Should not fix
foo.forEach(foo => bar());->
for (const foo of foo) bar();a[foo].forEach(foo => bar());->
for (const foo of a[foo]) bar();Should fix
a((foo) => foo).forEach(foo => bar());->
for (const foo of a((foo) => foo)) bar();There was a problem hiding this comment.
Figured a way to detect this, but not very efficient.
There was a problem hiding this comment.
A similar logic maybe possible to auto fix destructuring parameters, but it's much complicated, I'm going to try in a seperate PR.
# Conflicts: # index.js # readme.md
|
|
|
This is really well done (as always). And a super useful rule. 🙌🏻 |
fisker
commented
Jan 19, 2021
| > Output | ||
|
|
||
| `␊ | ||
| 1 | for (const [foo, index] of a((foo, index) => foo + index).entries()) bar();␊ |
There was a problem hiding this comment.
I was stupid, forgot to swap parameters.
|
You're killin' it, @fisker! 🥳 |
Repository owner
deleted a comment from
isghe
Mar 13, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #955
Not done yet, still twoTODOs need fix.