Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-array-callback-reference: Improve suggestions for Array#forEach() #1049

Merged
merged 1 commit into from Jan 22, 2021
Merged

no-array-callback-reference: Improve suggestions for Array#forEach() #1049

merged 1 commit into from Jan 22, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jan 22, 2021

Should not return value in forEach callback.

- foo.forEach((element) => fn(element), thisArgument)
+ foo.forEach((element) => { fn(element); }, thisArgument)

@fisker fisker changed the title no-array-callback-reference: Improve suggestion for Array#forEach() no-array-callback-reference: Improve suggestions for Array#forEach() Jan 22, 2021
@sindresorhus sindresorhus merged commit 77bcdc6 into sindresorhus:master Jan 22, 2021
@fisker fisker deleted the no-array-callback-reference-fix branch January 22, 2021 17:27
This was referenced Mar 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sindresorhus