prefer-string-slice: Keep optional chaining in autofix
#1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about |
|
And |
This is already tested
I'll add this one in an hour or so |
sindresorhus
approved these changes
Feb 6, 2021
fisker
reviewed
Feb 6, 2021
| }, | ||
| { | ||
| code: 'foo.bar.substr?.()', | ||
| output: 'foo.bar.slice?.()', |
There was a problem hiding this comment.
I'm not sure about this, the old one is testing object has .substr, but new one testing .slice exists, if someone mean to test it is a string and foo.bar is an array, it's broken.
fisker
approved these changes
Feb 6, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep optional chaining in auto fix
Fixes #999