prevent-abbreviations: Ignore i18n and l10n
#1445
Conversation
rules/prevent-abbreviations.js
Outdated
| @@ -96,6 +96,10 @@ const getNameReplacements = (name, options, limit = 3) => { | |||
| return {total: 0}; | |||
| } | |||
|
|
|||
| if (name.includes('i18n')) { | |||
There was a problem hiding this comment.
It should not be hard-coded directly here. There should be an internal list like allowList that is checked in the above if-statement.
There was a problem hiding this comment.
Done!
I added i18n and l10n to defaultAllowList.
But we should probably move it to defaultReplacements, because something like const i18nData = {} will not work, and it will still suggests to refactor it to index18nData but that's wrong.
What do you think ? 馃槃
There was a problem hiding this comment.
It's known #752, you'll have to use ignore option for now.
There was a problem hiding this comment.
Right, so I added defaultIgnore, should we also, add a new option, extendDefaultIgnore ?
There was a problem hiding this comment.
Right, so I added defaultIgnore, should we also, add a new option, extendDefaultIgnore ?
Nah. We can add it when it's needed. I see no reason to not want these ignores.
|
Let's ignore |
sindresorhus
changed the title
i18nprevent-abbreviations: Ignore i18n and l10n
Hey 馃憢,
This PR fixes #1188
It ignores the
i18nkeyword for theprevent-abbreviationsrule, as it is well-known and popular enough.I also like the idea of, explicit > implicit, but sometimes, things are done like that, so we can relax a bit the rule.