Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with ESLint 7 #1548

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Fix compatibility with ESLint 7 #1548

merged 3 commits into from
Oct 12, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Oct 12, 2021 •
edited

I dropped support for ESLint 7 in #1488 because the AST change make our tests hard to pass on ESLint 7.
But it can work on ESLint 7 with slight different results.

I agree

Supporting both versions would be ideal because this is going to be a lengthy transition as we need to wait until all of our eslint plugins support 8 before we can upgrade eslint.

Fixes #1544
Fixes #1546

@sindresorhus sindresorhus changed the title Fix error on ESLint 7 Fix compatibility with ESLint 7 Oct 12, 2021
@sindresorhus sindresorhus merged commit e6cee0f into sindresorhus:main Oct 12, 2021
@fisker fisker deleted the eslint-7 branch October 12, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fisker @sindresorhus