Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Ramda methods in rules #1557

Merged
merged 3 commits into from Oct 21, 2021
Merged

Ignore Ramda methods in rules #1557

merged 3 commits into from Oct 21, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Oct 20, 2021

#1386 (comment)

@fisker I have no idea why tests fail.

@fisker
Copy link
Collaborator

fisker commented Oct 20, 2021

Maybe you have an outdated version of ava. Anyway, I ran npx ava test/no-array-for-each.mjs -u fixed the snapshot files.

@JounQin
Copy link
Contributor Author

JounQin commented Oct 20, 2021 •
edited

Maybe you have an outdated version of ava. Anyway, I ran npx ava test/no-array-for-each.mjs -u fixed the snapshot files.

I'm on a fresh new project, actually, eslint version is conflict, I have to lock eslint@7 and then revert this change to run test.

I was running yarn test instead of npx ava test/no-array-for-each.mjs -u.

@sindresorhus sindresorhus changed the title feat: ignore ramda methods Ignore Ramda methods in rules Oct 21, 2021
@sindresorhus sindresorhus merged commit 5f3bad5 into sindresorhus:main Oct 21, 2021
@JounQin JounQin deleted the feat/ramda branch October 21, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisker fisker fisker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JounQin @fisker @sindresorhus