Enhance no-array-for-each to handle optional chaining
#1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
requested changes
Mar 21, 2022
|
Tests are not enough, please duplicate all these cases , change to?. and test them all.
|
This comment was marked as outdated.
This comment was marked as outdated.
|
Forget about the indention, let other rule handle it, even if (foo) for (const returnStatement of returnStatements) {
// ...
}is fine to me. |
fisker
reviewed
Mar 24, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
fisker
reviewed
Mar 28, 2022
fisker
reviewed
Mar 29, 2022
fisker
reviewed
Mar 30, 2022
# Conflicts: # rules/no-array-for-each.js # test/snapshots/no-array-for-each.mjs.md # test/snapshots/no-array-for-each.mjs.snap
fisker
approved these changes
Mar 31, 2022
|
@zaicevas Please take a look, please let me know if you find something wrong. |
|
|
I'll take a look later today |
zaicevas
commented
Mar 31, 2022
|
Thanks for contributing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1632
That's my first contribution, so let me know if I missed anything 馃槄