Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-array-for-each: Handle ChainExpression correctly #1772

Merged
merged 4 commits into from Mar 30, 2022
Merged

no-array-for-each: Handle ChainExpression correctly #1772

merged 4 commits into from Mar 30, 2022

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Mar 30, 2022

This PR not handling array?.forEach() or array.forEach?.(), just handle an unrelated ChainExpression node correctly.

foo?.bar.forEach(...)

Should be fixable, because the array and the forEach call are not optional.

@fisker fisker marked this pull request as ready for review March 30, 2022 09:16
@fisker fisker mentioned this pull request Mar 30, 2022
Merged
@sindresorhus sindresorhus merged commit e615a37 into sindresorhus:main Mar 30, 2022
@fisker fisker deleted the no-array-for-each-chain-expression branch March 31, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fisker @sindresorhus