Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefer-logical-operator-over-ternary rule #1830

Merged

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented May 26, 2022

Fixes #1798

The rule name is not final. #1798 (comment)

@fisker fisker marked this pull request as ready for review May 26, 2022 11:47
@fisker fisker marked this pull request as draft June 29, 2022 02:36
@fisker fisker marked this pull request as ready for review June 29, 2022 05:37
fisker and others added 2 commits June 29, 2022 13:39
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@fisker
Copy link
Collaborator Author

fisker commented Jun 29, 2022

Suggestions applied.

Are you fine with the rule name?

@sindresorhus
Copy link
Owner

Are you fine with the rule name?

👍

@sindresorhus sindresorhus merged commit 5d7e622 into sindresorhus:main Jun 30, 2022
@fisker fisker deleted the prefer-logical-operator-over-ternary branch June 30, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule proposal: no-useless-ternary
2 participants